<html>
<head><meta charset="utf-8"><title>build-script-envvars · t-cargo · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/index.html">t-cargo</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/build-script-envvars.html">build-script-envvars</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="244746695"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/build-script-envvars/near/244746695" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jon Gjengset <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/build-script-envvars.html#244746695">(Jul 02 2021 at 19:19)</a>:</h4>
<p><span class="user-mention" data-user-id="116015">@Alex Crichton</span> Were there additional changes you wanted me to make to <a href="https://github.com/rust-lang/cargo/pull/9601">https://github.com/rust-lang/cargo/pull/9601</a>? If not, I think it now addresses all your comments. There's also <span class="user-mention" data-user-id="138448">@cuviper</span>'s question about <code>RUSTC_WORKSPACE_WRAPPER</code>, which you may have a better take on than I do.</p>



<a name="244754661"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/build-script-envvars/near/244754661" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/build-script-envvars.html#244754661">(Jul 02 2021 at 20:35)</a>:</h4>
<p>sorry I've been busy with other stuff this week, I will try to respond later today</p>



<a name="245341737"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/build-script-envvars/near/245341737" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jon Gjengset <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/build-script-envvars.html#245341737">(Jul 08 2021 at 17:04)</a>:</h4>
<p>Gentle nudge on this again — it should now reflect the latest requested changes.</p>



<a name="245357293"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/build-script-envvars/near/245357293" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/build-script-envvars.html#245357293">(Jul 08 2021 at 19:06)</a>:</h4>
<p>Alex is on vacation, so it may be a while before he can get back to you.</p>



<a name="246170352"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/build-script-envvars/near/246170352" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jon Gjengset <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/build-script-envvars.html#246170352">(Jul 15 2021 at 23:53)</a>:</h4>
<p>Hey folks. Just wanted to follow up on <a href="https://github.com/rust-lang/cargo/pull/9601">https://github.com/rust-lang/cargo/pull/9601</a> — I'm leaving for vacation for a few weeks late tomorrow, so wanted to get a sense of whether I should remove the versioning envvar for now in the hopes of it landing while I'm away, or whether I should leave it as-is?</p>



<a name="246172362"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/build-script-envvars/near/246172362" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/build-script-envvars.html#246172362">(Jul 16 2021 at 00:25)</a>:</h4>
<p><span class="user-mention" data-user-id="120054">@Jon Gjengset</span> please go ahead and drop the version environment variable, so that we can review the rest independently. That doesn't mean we're going to reject the version environment variable, but I think it's reasonably plausible we may want to consider it independently.</p>



<a name="246172414"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/build-script-envvars/near/246172414" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/build-script-envvars.html#246172414">(Jul 16 2021 at 00:26)</a>:</h4>
<p>Thank you for thinking about that.</p>



<a name="246174128"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/build-script-envvars/near/246174128" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jon Gjengset <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/build-script-envvars.html#246174128">(Jul 16 2021 at 00:55)</a>:</h4>
<p>Done!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>